This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Issue 200 fix intersection #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t::_filter_covered() depending on its coordinate dimension.
…-solid intersection and store as separate primitives.
* Experienced exception in ekt reader owing to fact that specified triangle is defined with 5 vertices (one duplicate), rather than 4.
|
@danielcumberbatch Thanks for your proposition. I am lacking time to review your PR in depth. But at first sight, I see you are using Nef_polyhedron, which we decided to avoid, because it is very slow. We rely on corefinement for boolean operations. See here for instance. |
|
@mhugo thanks for your comment. I will review the reference that you have sent and update my submission. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #200.